Feat: Add LLDB log creation setting, improve logs

1 files changed, 16 insertions, 3 deletions

diff --git a/Scripts/main.js b/Scripts/main.js
index 1058dfe..d9aac14 100644
--- a/Scripts/main.js
+++ b/Scripts/main.js
@@ -12,6 +12,7 @@ const CONFIG_KEYS = {
   zlsEnabled: `${EXTENSION_ID}.zls.enabled`,
   zlsBuildOnSave: `${EXTENSION_ID}.zls.build-on-save`,
   zlsDebug: `${EXTENSION_ID}.zls.debug`,
+  lldbDapDebug: `${EXTENSION_ID}.debug-adapter.debug`,
 };
 
 let languageServer = null;
@@ -264,7 +265,7 @@ function lldbDapProxyPath() {
 }
 
 function debugAdapterLogPath() {
-  return "/tmp/zig-lldb-dap-proxy.log";
+  return nova.path.join(nova.extension.globalStoragePath, "lldb-dap-proxy.log");
 }
 
 function issueNormalizerScriptPath() {
@@ -806,12 +807,24 @@ class ZigTaskAssistant {
     const action = new TaskDebugAdapterAction("zig-lldb-dap");
     action.transport = "stdio";
     action.command = "/usr/bin/perl";
-    action.args = [lldbDapProxyPath(), lldbDapPath, debugAdapterLogPath()];
+    const debugLog = getBooleanConfigValue(CONFIG_KEYS.lldbDapDebug, false);
+    let logPath;
+    if (debugLog) {
+      try {
+        const p = debugAdapterLogPath();
+        const dir = nova.path.dirname(p);
+        if (!nova.fs.stat(dir)) nova.fs.mkdir(dir);
+        logPath = p;
+      } catch (_) {}
+    }
+    action.args = logPath
+      ? [lldbDapProxyPath(), lldbDapPath, logPath]
+      : [lldbDapProxyPath(), lldbDapPath];
     action.debugRequest = "launch";
     action.env = {
       DYLD_FRAMEWORK_PATH: lldbFrameworkPaths().join(":"),
       NOVA_ZIG_LLDB_DAP_PATH: lldbDapPath,
-      NOVA_ZIG_DEBUG_LOG: debugAdapterLogPath(),
+      ...(logPath ? { NOVA_ZIG_DEBUG_LOG: logPath } : {}),
     };
     action.debugArgs = {
       program: programPath,